Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Razor.Language API polish #1510

Closed
26 tasks done
NTaylorMullen opened this issue Jul 6, 2017 · 3 comments
Closed
26 tasks done

Razor.Language API polish #1510

NTaylorMullen opened this issue Jul 6, 2017 · 3 comments
Assignees
@rynowak @ajaybhargavb @NTaylorMullen
Labels
3 - Done enhancement
Milestone
2.0.0

Comments

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Jul 6, 2017 •
edited by ajaybhargavb
Loading

General

  • Make DocumentClassifierPassBase.TargetExtensions private. - @NTaylorMullen
  • IRazorEngineBuilder.DesignTime should be getter only. - @NTaylorMullen
  • RazorCSharpDocument.GeneratedCode should be renamed to Code. - @NTaylorMullen - Unimportant/too cross-cutting for repos.
  • Rename RazorEngineFeatureBase.ThrowForMissingEngineDependency to ThrowForMissingFeatureDependency - @NTaylorMullen
  • Rename RazorEnginePhaseBase.ThrowForMissingEngineDependency to ThrowForMissingFeatureDependency - @NTaylorMullen
  • Find all instances of base / path and rename them to FilePath / BasePath - @ajaybhargavb
  • Abstractify ICodeTargetBuilder. - @ajaybhargavb
  • IntermediateNodeWalker should be indexable - @ajaybhargavb
  • Do a pass on all IntermediateNodes and cross-check the verbosity of their properties. They should be consistent which may mean having more verbose properties. - @ajaybhargavb
  • Unnest IntermediateToken.TokenKind - @ajaybhargavb
  • Make TagHelperIntermediateNode.TagHelpers an IList - @ajaybhargavb

HtmlConventions.InvalidNonWhitespaceHtmlCharacters - @ajaybhargavb

  • Make internal.
  • Make non-hashset.

LineMapping - @NTaylorMullen

  • Rename to SourceMapping.
  • Remove == and != operators.

RazorParserOptions - @NTaylorMullen

  • Add CreateDesignTime method
  • Rename ParseOnlyLeadingDirectives => ParseLeadingDirectives

RazorParserOptionsBuilder - @NTaylorMullen

  • DesignTime should be getter only.
  • Rename ParseOnlyLeadingDirectives => ParseLeadingDirectives

TagHelperBinding - @NTaylorMullen

  • Attributes should be IReadOnlyList if it makes sense.
  • GetBoundRules should return IReadOnlyList if it makes sense.

TagHelper descriptors in general - @NTaylorMullen

  • See if TagHelperDescriptor.AllowedChildTags can be IReadOnlyList
  • See if TagHelperDescriptor.BoundAttributes can be IReadOnlyList
  • See if TagHelperDescriptor.TagMatchingRules can be IReadOnlyList
  • See if TagMatchingRuleDescriptor.Attributes can be IReadOnlyList
  • See if TagMatchingRuleDescriptor.Attributes can be IReadOnlyList
@NTaylorMullen NTaylorMullen added this to the 2.0.0 milestone Jul 6, 2017
@NTaylorMullen
Copy link
Contributor Author

When working on one of these lets put our name next to the items or item header so we don't duplicate work.

NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename LineMapping => SourceMapping.
914eaef 
- Also removed the == and `!=` operators for `SourceMapping`.

#1510
@NTaylorMullen NTaylorMullen mentioned this issue Jul 6, 2017
Merged
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename LineMapping => SourceMapping.
afa61e7 
- Also removed the == and `!=` operators for `SourceMapping`.

#1510
@NTaylorMullen
Copy link
Contributor Author

NTaylorMullen commented Jul 6, 2017 •
edited
Loading

afa61e7
87a5435
b68290d
cb40da4
aspnet/Mvc@1be7960
c34a99e
bba508c
d891fae
d891fae

@ajaybhargavb ajaybhargavb mentioned this issue Jul 6, 2017
Merged
@ajaybhargavb
Copy link
Contributor

ajaybhargavb commented Jul 6, 2017 •
edited
Loading

11c5293
6fdd4d6
d6e892b
aspnet/Mvc@8bc4d7b
aspnet/Mvc@05f5d59
49eab41
267b3fa
b70815e

NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Make RazorParserOptions.DesignTime getter only.
4575d7b 
- Renamed `IRazorParserOptionsFeature` to `IConfigureRazorParserOptionsFeature`, the original interface was re-purposed to get the options rather than configure them.
- This involved re-designing how we set design time on the `RazorParserOptions` object. The indicator of `DesignTime` is now configured at the RazorEngine level via a parser options provider feature.
- Moved options construction from the phase into an `IRazorParserOptionsFeature` type.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Make RazorParserOptions.DesignTime getter only.
d3c25c4 
- Renamed `IRazorParserOptionsFeature` to `IConfigureRazorParserOptionsFeature`, the original interface was re-purposed to get the options rather than configure them.
- This involved re-designing how we set design time on the `RazorParserOptions` object. The indicator of `DesignTime` is now configured at the RazorEngine level via a parser options provider feature.
- Moved options construction from the phase into an `IRazorParserOptionsFeature` type.

#1510
@NTaylorMullen NTaylorMullen mentioned this issue Jul 6, 2017
Merged
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Make RazorParserOptions creation more like RazorEngine
98172d5 
- Removed verbose `Create` methods in favor of the `RazorParserOptionsBuilder`. This is similar to how the `RazorEngine` functions.
- Added a `CreateDesignTime` method.
- Updated existing tests to use new Create syntax.

#1510
@NTaylorMullen NTaylorMullen mentioned this issue Jul 6, 2017
Closed
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename ParseOnlyLeadingDirectives.
2359cac 
- Was renamed to `ParseLeadingDirectives`.

#1510
@NTaylorMullen NTaylorMullen mentioned this issue Jul 6, 2017
Closed
NTaylorMullen added a commit to aspnet/Mvc that referenced this issue Jul 6, 2017
@NTaylorMullen
React to IRazorParserOptionsFeature rename.
d71fb89 
aspnet/Razor#1510
NTaylorMullen added a commit to aspnet/Mvc that referenced this issue Jul 6, 2017
@NTaylorMullen
React to ParseOnlyLeadingDirectives rename.
1be7960 
aspnet/Razor#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Make RazorParserOptions.DesignTime getter only.
87a5435 
- Renamed `IRazorParserOptionsFeature` to `IConfigureRazorParserOptionsFeature`, the original interface was re-purposed to get the options rather than configure them.
- This involved re-designing how we set design time on the `RazorParserOptions` object. The indicator of `DesignTime` is now configured at the RazorEngine level via a parser options provider feature.
- Moved options construction from the phase into an `IRazorParserOptionsFeature` type.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Make RazorParserOptions creation more like RazorEngine
b68290d 
- Removed verbose `Create` methods in favor of the `RazorParserOptionsBuilder`. This is similar to how the `RazorEngine` functions.
- Added a `CreateDesignTime` method.
- Updated existing tests to use new Create syntax.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename ParseOnlyLeadingDirectives.
cb40da4 
- Was renamed to `ParseLeadingDirectives`.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Update the TagHelperBinding API to use IReadOnlyList.
4b980bf 
- Changed `Attributes` to return `IReadOnlyList<KeyValuePair<string, string>>`.
- Changed `GetBoundRules` to return `IReadOnlyList<TagMatchingRuleDescriptor>`.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Update the TagHelperBinding API to use IReadOnlyList.
34662aa 
- Changed `Attributes` to return `IReadOnlyList<KeyValuePair<string, string>>`.
- Changed `GetBoundRules` to return `IReadOnlyList<TagMatchingRuleDescriptor>`.
- Updated tests to react to new signature.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Update the TagHelperBinding API to use IReadOnlyList.
8544420 
- Changed `Attributes` to return `IReadOnlyList<KeyValuePair<string, string>>`.
- Changed `GetBoundRules` to return `IReadOnlyList<TagMatchingRuleDescriptor>`.
- Updated tests to react to new signature.

#1510
@NTaylorMullen NTaylorMullen mentioned this issue Jul 6, 2017
Merged
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Update the TagHelperBinding API to use IReadOnlyList.
c34a99e 
- Changed `Attributes` to return `IReadOnlyList<KeyValuePair<string, string>>`.
- Changed `GetBoundRules` to return `IReadOnlyList<TagMatchingRuleDescriptor>`.
- Updated tests to react to new signature.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Change TagHelperDescriptor APIs to use IReadOnlyList.
a0a03aa 
- Change `TagHelperDescriptor.AllowedChildTags` to be `IReadOnlyList`.
- Change `TagHelperDescriptor.BoundAttributes` to be `IReadOnlyList`.
- Change `TagHelperDescriptor.TagMatchingRules` to be `IReadOnlyList`.
- Change `TagMatchingRuleDescriptor.Attributes` to be `IReadOnlyList`.

#1510
@NTaylorMullen NTaylorMullen mentioned this issue Jul 6, 2017
Merged
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Change TagHelperDescriptor APIs to use IReadOnlyList.
bba508c 
- Change `TagHelperDescriptor.AllowedChildTags` to be `IReadOnlyList`.
- Change `TagHelperDescriptor.BoundAttributes` to be `IReadOnlyList`.
- Change `TagHelperDescriptor.TagMatchingRules` to be `IReadOnlyList`.
- Change `TagMatchingRuleDescriptor.Attributes` to be `IReadOnlyList`.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename several APIs.
a5d97d7 
- Rename `RazorCSharpDocument.GeneratedCode` to `Code`.
- Rename `RazorEngineFeatureBase.ThrowForMissingEngineDependency` to `ThrowForMissingFeatureDependency`
- Rename `RazorEnginePhaseBase.ThrowForMissingEngineDependency` to `ThrowForMissingFeatureDependency`

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Reduce public surface area of some APIs.
157bef1 
- Change `DefaultRazorEngineBuilder.DesignTime` to be getter only
- Make `DocumentClassifierPassBase.TargetExtensions` private.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename ThrowForMissingEngineDependency.
39cee43 
- Rename `RazorEngineFeatureBase.ThrowForMissingEngineDependency` to `ThrowForMissingFeatureDependency`
- Rename `RazorEnginePhaseBase.ThrowForMissingEngineDependency` to `ThrowForMissingFeatureDependency`

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Reduce public surface area of some APIs.
aed96c1 
- Change `DefaultRazorEngineBuilder.DesignTime` to be getter only
- Make `DocumentClassifierPassBase.TargetExtensions` private.

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Rename ThrowForMissingEngineDependency.
d891fae 
- Rename `RazorEngineFeatureBase.ThrowForMissingEngineDependency` to `ThrowForMissingFeatureDependency`
- Rename `RazorEnginePhaseBase.ThrowForMissingEngineDependency` to `ThrowForMissingFeatureDependency`

#1510
NTaylorMullen added a commit that referenced this issue Jul 6, 2017
@NTaylorMullen
Reduce public surface area of some APIs.
45fad17 
- Change `DefaultRazorEngineBuilder.DesignTime` to be getter only
- Make `DocumentClassifierPassBase.TargetExtensions` private.

#1510
This was referenced Jul 7, 2017
Merged
Closed
Merged
Merged
@ajaybhargavb ajaybhargavb mentioned this issue Jul 7, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

@ajaybhargavb ajaybhargavb

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@rynowak @ajaybhargavb @NTaylorMullen