This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Adding IFilterFactory #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a generalized factory/provider for filters - TypeFilterAttribute and ServiceFilterAttribute are now implemented in terms of this interface.
|
Looks |
to me, but awaiting 
|
|
||
| namespace Microsoft.AspNet.Mvc | ||
| { | ||
| public interface IFilterFactory : IFilter |
There was a problem hiding this comment.
I believe filter factory needs order, otherwise you can't apply it globally and get it ordered against other filters
There was a problem hiding this comment.
If you need order you can just also implement IOrderedFilter. Our two implementations have both interfaces.
There was a problem hiding this comment.
As discussed, will open a follow up by for global filters, will include details about the need to include ordering on IFilterFactory when that's implemented.
Edit: #349 filed
|
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a generalized factory/provider for filters - TypeFilterAttribute
and ServiceFilterAttribute are now implemented in terms of this interface.