This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Finish split to Extensions + optional roles #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoK
commented
Jun 14, 2017
| @@ -30,32 +30,68 @@ public static IdentityBuilder AddEntityFrameworkStores<TContext>(this IdentityBu | |||
|
|
|||
| private static void AddStores(IServiceCollection services, Type userType, Type roleType, Type contextType) | |||
There was a problem hiding this comment.
This is the important method to review, as its doing the mega type inference we need to do for the custom poco scenario
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269 and #1253
Support for:
@ajcvickers @blowdart @divega
Actually landed ok, I needed to expose a few more EFCore types
UserOnlyStore (naming?) which is a IUserStore that implements everything except the roles ones. And a few IdentityDbContext class overloads that omit the role related entities.
Existing tests all pass, and I added a few variations on running with only users enabled. I still need to add a varation that runs with users + roles via the new builder APIs, and also a variation that runs against a DbContext that doesn't derive from identityDbContext.