Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Cleanup: Move more classes from Microsoft.AspNetCore.Identity into Extensions #1253

Closed
HaoK opened this issue May 30, 2017 · 3 comments
Closed
Assignees
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented May 30, 2017

IdentityBuilder, and a few other classes like validators can be moved into Extensions as well

@HaoK HaoK self-assigned this May 30, 2017
@HaoK HaoK added this to the 2.0.0 milestone May 30, 2017
@HaoK
Copy link
Member Author

HaoK commented Jun 2, 2017

@ajcvickers is this still considered cleanup? Basically moving classes between assemblies, would not have any real customer impact as currently they always get the AspNetCore assembly, we'd just be enabling more stuff working when using the new Microsoft.Extensions.Identity...

But using a strict interpretation of 'features', this would be enabling some scenarios around that (using Microsoft.Extensions.Identity directly)...

@ajcvickers
Copy link
Contributor

@HaoK If it doesn't impact any customer experience and won't break apps, then it's fine to do post preview2.

@HaoK
Copy link
Member Author

HaoK commented Jun 14, 2017

Tracking this via #1269

@HaoK HaoK closed this as completed Jun 14, 2017
@HaoK HaoK removed the 2 - Working label Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants