Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update some dependencies versions (#22228) #22260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Mar 8, 2025

Helps with #22228

Bumped some versions.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner March 8, 2025 15:48
Copy link

bunnyshell bot commented Mar 8, 2025

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-ja72ou.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-ja72ou.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@andrii-korotkov-verkada andrii-korotkov-verkada changed the title chore(deps): Update some dependencies versions and bump go to 1.24.1 (#22228) chore(deps): Update some dependencies versions (#22228) Mar 8, 2025
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from 04def74 to 9f52056 Compare March 8, 2025 16:02
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.89%. Comparing base (42219fd) to head (e4f007c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/apiclient.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22260      +/-   ##
==========================================
- Coverage   55.90%   55.89%   -0.02%     
==========================================
  Files         343      343              
  Lines       57305    57305              
==========================================
- Hits        32036    32030       -6     
- Misses      22624    22628       +4     
- Partials     2645     2647       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-korotkov-verkada
Copy link
Contributor Author

go.mod Outdated
Comment on lines 295 to 300
github.com/google/go-jsonnet => github.com/andrii-korotkov-verkada/go-jsonnet v0.0.0-20250308155707-03f98b787f0e
github.com/grpc-ecosystem/grpc-gateway => github.com/grpc-ecosystem/grpc-gateway v1.16.0
github.com/improbable-eng/grpc-web => github.com/andrii-korotkov-verkada/grpc-web v0.0.0-20250308221419-d37df84c6882
github.com/olekukonko/tablewriter => github.com/andrii-korotkov-verkada/tablewriter v0.0.0-20250308155854-8571ed54aa92
github.com/r3labs/diff/v3 => github.com/andrii-korotkov-verkada/diff/v3 v3.0.0-20250308155935-ef18f9606732
github.com/soheilhy/cmux => github.com/andrii-korotkov-verkada/cmux v0.0.0-20250308160011-2ab3fff3705c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't think we should do this. imo using a fork of a lightly-maintained library is worse than just using the lightly-maintained library.

@andrii-korotkov-verkada
Copy link
Contributor Author

@crenshaw-dev
Copy link
Member

That's one option. But in each case we should have a good reason why we're adding the replace. The only justification I can think of is the presence of a high- or critical-severity vulnerability or a lower-severity vulnerability that's been shown to directly impact our users.

@andrii-korotkov-verkada
Copy link
Contributor Author

@crenshaw-dev, I've reverted the fork changes

@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from 9ed41d6 to ebdd52e Compare March 10, 2025 18:53
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from f70e0e1 to df83193 Compare March 10, 2025 19:38
Signed-off-by: Andrii Korotkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

2 participants