-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update some dependencies versions (#22228) #22260
base: master
Are you sure you want to change the base?
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
04def74
to
9f52056
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22260 +/- ##
==========================================
- Coverage 55.90% 55.89% -0.02%
==========================================
Files 343 343
Lines 57305 57305
==========================================
- Hits 32036 32030 -6
- Misses 22624 22628 +4
- Partials 2645 2647 +2 ☔ View full report in Codecov by Sentry. |
6037ec3
to
c374625
Compare
I haven’t seen ctx logrus in those while working on versions upgrades
…On Monday, March 10, 2025, Michael Crenshaw ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In util/grpc/logging.go
<#22260 (comment)>:
> @@ -83,7 +82,7 @@ func reportable(entry *logrus.Entry, callType string, logClaims bool) intercepto
return func(ctx context.Context, c interceptors.CallMeta) (interceptors.Reporter, context.Context) {
return &reporter{
ctx: ctx,
- entry: entry.WithFields(ctx_logrus.Extract(ctx).Data),
+ entry: entry,
Is it possible that ctx_logrus is called by external code? Maybe pkg or
gitops-engine?
—
Reply to this email directly, view it on GitHub
<#22260 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAXACXQHN6AJJFHWNMVPZ732TWZMNAVCNFSM6AAAAABYTFKCAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZRGMYDCOJSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
go.mod
Outdated
github.com/google/go-jsonnet => github.com/andrii-korotkov-verkada/go-jsonnet v0.0.0-20250308155707-03f98b787f0e | ||
github.com/grpc-ecosystem/grpc-gateway => github.com/grpc-ecosystem/grpc-gateway v1.16.0 | ||
github.com/improbable-eng/grpc-web => github.com/andrii-korotkov-verkada/grpc-web v0.0.0-20250308221419-d37df84c6882 | ||
github.com/olekukonko/tablewriter => github.com/andrii-korotkov-verkada/tablewriter v0.0.0-20250308155854-8571ed54aa92 | ||
github.com/r3labs/diff/v3 => github.com/andrii-korotkov-verkada/diff/v3 v3.0.0-20250308155935-ef18f9606732 | ||
github.com/soheilhy/cmux => github.com/andrii-korotkov-verkada/cmux v0.0.0-20250308160011-2ab3fff3705c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't think we should do this. imo using a fork of a lightly-maintained library is worse than just using the lightly-maintained library.
But their dependencies are quite old. Should I just use replace on
dependencies of the libs?
…On Monday, March 10, 2025, Michael Crenshaw ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In go.mod
<#22260 (comment)>:
> + github.com/google/go-jsonnet => github.com/andrii-korotkov-verkada/go-jsonnet v0.0.0-20250308155707-03f98b787f0e
github.com/grpc-ecosystem/grpc-gateway => github.com/grpc-ecosystem/grpc-gateway v1.16.0
+ github.com/improbable-eng/grpc-web => github.com/andrii-korotkov-verkada/grpc-web v0.0.0-20250308221419-d37df84c6882
+ github.com/olekukonko/tablewriter => github.com/andrii-korotkov-verkada/tablewriter v0.0.0-20250308155854-8571ed54aa92
+ github.com/r3labs/diff/v3 => github.com/andrii-korotkov-verkada/diff/v3 v3.0.0-20250308155935-ef18f9606732
+ github.com/soheilhy/cmux => github.com/andrii-korotkov-verkada/cmux v0.0.0-20250308160011-2ab3fff3705c
I really don't think we should do this. imo using a fork of a
lightly-maintained library is worse than just using the lightly-maintained
library.
—
Reply to this email directly, view it on GitHub
<#22260 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAXACXVWZIKAETQXLKMGKOL2TXLKLAVCNFSM6AAAAABYTFKCAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZRG42DGNRTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
That's one option. But in each case we should have a good reason why we're adding the |
@crenshaw-dev, I've reverted the fork changes |
9ed41d6
to
ebdd52e
Compare
Signed-off-by: Andrii Korotkov <[email protected]>
f70e0e1
to
df83193
Compare
Signed-off-by: Andrii Korotkov <[email protected]>
Helps with #22228
Bumped some versions.
Checklist: