Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate EndpointResolverWithOptionsFunc, WithEndpointResolverWithOptions etc. in notifications engine #22140

Open
andrii-korotkov-verkada opened this issue Mar 3, 2025 · 1 comment
Open

Deprecate EndpointResolverWithOptionsFunc, WithEndpointResolverWithOptions etc. in notifications engine #22140

andrii-korotkov-verkada opened this issue Mar 3, 2025 · 1 comment
Assignees
@andrii-korotkov-verkada
Labels
component:notifications Related to notifications subsystem enhancement New feature or request

Comments

@andrii-korotkov-verkada
Copy link
Contributor

Summary

The functionality needs to be migrated to the new API.
See argoproj/notifications-engine#360 for where the todos were introduced.

Motivation

Don't use deprecated functionality.

Proposal

Do the migration to new APIs.
@andrii-korotkov-verkada andrii-korotkov-verkada added component:notifications Related to notifications subsystem enhancement New feature or request labels Mar 3, 2025
Merged
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/notifications-engine that referenced this issue Mar 9, 2025
@andrii-korotkov-verkada
chore: Deprecate EndpointResolver v1, bump some deps
3e78806 
Helps with: argoproj/argo-cd#22140

Remove deprecated functionality, moving to per-service endpoint and region resolution.
Also, bump some dependencies.

Signed-off-by: Andrii Korotkov <[email protected]>
Merged
pasha-codefresh added a commit to argoproj/notifications-engine that referenced this issue Mar 9, 2025
@andrii-korotkov-verkada @pasha-codefresh
chore: Deprecate EndpointResolver v1, bump some deps (#365)
87bf057 
Helps with: argoproj/argo-cd#22140

Remove deprecated functionality, moving to per-service endpoint and region resolution.
Also, bump some dependencies.

Signed-off-by: Andrii Korotkov <[email protected]>
Co-authored-by: Pasha Kostohrys <[email protected]>
@andrii-korotkov-verkada
Copy link
Contributor Author

andrii-korotkov-verkada commented Mar 9, 2025 •
edited
Loading

Notifications engine is being updated as a part of #22260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii-korotkov-verkada andrii-korotkov-verkada

Labels
component:notifications Related to notifications subsystem enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrii-korotkov-verkada