Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: disabled ssh sockets which can interfear with ted #37183

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

yatinappsmith
Copy link
Contributor

@yatinappsmith yatinappsmith commented Nov 1, 2024

Description

disabled ssh sockets which can interfear with ted

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Enhanced CI test workflow for improved job configuration and execution logic.
    • Added SSH access for the test-event-driver service and introduced controls for SSH service during tests.
    • Improved caching mechanism for better test reruns management.
    • Streamlined environment variable management for Cypress tests.

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the CI workflow for Appsmith, focusing on the ci-test-custom-script.yml file. Key changes include updates to the docker run command for the test-event-driver service to allow SSH access, the introduction of logic to disable the SSH service during tests, and refinements to job conditions based on GitHub event types. Additionally, improvements to caching mechanisms and error handling have been implemented, enhancing the overall management of test execution and Docker container operations.

Changes

File Path Change Summary
.github/workflows/ci-test-custom-script.yml - Updated docker run command for test-event-driver to include SSH port mapping (port 22).
- Introduced command to disable the SSH service during tests.
- Refined job conditions for triggering CI tests based on GitHub event types.
- Improved caching mechanism for restoring and saving previous run results.
- Enhanced logic for determining run results to decide on reruns of failed tests.
- Streamlined environment variable management for Cypress tests based on input parameters.

Possibly related PRs

  • ci: Removed port 22 from ted in ci-test #37180: The changes in this PR directly relate to the main PR as both involve modifications to the docker run command for the test-event-driver service in the CI workflow, specifically regarding the SSH port configuration.

Suggested labels

skip-changelog, CI, ok-to-test

Suggested reviewers

  • sharat87
  • hetunandu

🎉 In the land of code where workflows thrive,
A CI script now comes alive!
With SSH ports and caching anew,
Tests run smoother, all thanks to you!
Docker's dance, with errors tamed,
In Appsmith's realm, progress is claimed! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yatinappsmith yatinappsmith merged commit 6c13656 into release Nov 1, 2024
13 of 15 checks passed
@yatinappsmith yatinappsmith deleted the ci/disablessh branch November 1, 2024 08:37
@hetunandu
Copy link
Member

hetunandu commented Nov 1, 2024

Reverts #37180 and disables the ssh socket itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants