ci: Removed port 22 from ted in ci-test #37180
Conversation
WalkthroughThe pull request modifies the CI workflow configuration in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| docker run --name test-event-driver -d -p 5001:5001 -p 3306:3306 \ | ||
| -p 5433:5432 -p 28017:27017 -p 25:25 -p 4200:4200 -p 5000:5000 -p 3001:3000 -p 6001:6001 -p 8001:8000 --privileged --pid=host --ipc=host --volume /:/host -v ~/git-server/keys:/git-server/keys \ |
There was a problem hiding this comment.
💡 Codebase verification
Port 22 removal is consistent with other workflow changes
The removal of port 22 mapping in ci-test-custom-script.yml is part of a deliberate security pattern. All workflow files stop the SSH service before running containers, and other workflow files (ci-test-limited.yml, ci-test-limited-with-count.yml, ci-debugging.yml) should also have port 22 mapping removed for consistency.
.github/workflows/ci-test-limited.yml: Remove-p 22:22from docker run command.github/workflows/ci-test-limited-with-count.yml: Remove-p 22:22from docker run command.github/workflows/ci-debugging.yml: Remove-p 22:22from docker run command
🔗 Analysis chain
Security improvement: SSH port removal
The removal of port 22 mapping enhances security by reducing the attack surface in the CI environment.
Let's verify that no CI operations depend on SSH access:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for SSH-related operations in the workflow files
rg -i "ssh|port.*22" .github/workflows/
Length of output: 359
Script:
#!/bin/bash
# Let's check the context around the SSH stop commands to understand their purpose
rg -B 5 -A 5 "ssh stop" .github/workflows/
# Also check if there are any SSH-related configurations or keys being used
rg -i "ssh.*key|ssh.*config" .github/workflows/
Length of output: 4494
hetunandu
changed the title
github-actions
bot
added
skip-changelog
Description
Removed port 22 from ted in ci-test
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11625284598
Commit: 8edce8c
Cypress dashboard.
Tags: @tag.Sanity
Spec:
The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts
- cypress/e2e/Regression/ClientSide/AppNavigation/AppNavigationWithGit_spec.ts
- cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
- cypress/e2e/Regression/ClientSide/Git/GitAutocommit_spec.ts
- cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
- cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncGitBugs_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
- cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js
- cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts
List of identified flaky tests.Fri, 01 Nov 2024 06:51:10 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit