Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ETH and WETH to swap options #727

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Add ETH and WETH to swap options #727

merged 1 commit into from
Jan 14, 2023

Conversation

nichosystem
Copy link
Contributor

@nichosystem nichosystem commented Jan 13, 2023 •
edited
Loading

Description

Part of #707

Checklist

  • Code follows the style guide
  • I have performed a self-review of my own code
  • New and existing tests pass locally
  • This PR is targeting the correct branch

@nichosystem nichosystem requested a review from a team as a code owner January 13, 2023 22:05
@github-actions github-actions bot added the dapp dapp related issues/PRs label Jan 13, 2023
frontier159
frontier159 approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@frontier159 frontier159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Obviously won't need approval for ETH either - i've assumed ensureAllowance() is smart enough to ignore that?

@nichosystem nichosystem merged commit d9472b3 into stage Jan 14, 2023
@nichosystem nichosystem deleted the feat/weth branch January 14, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshall2112 marshall2112 marshall2112 approved these changes

@frontier159 frontier159 frontier159 approved these changes

Assignees
No one assigned
Labels
dapp dapp related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nichosystem @marshall2112 @frontier159