Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Balancer Swap #707

Open
6 of 10 tasks
nichosystem opened this issue Jan 4, 2023 · 0 comments
Open
6 of 10 tasks

Polish Balancer Swap #707

nichosystem opened this issue Jan 4, 2023 · 0 comments
Assignees
@nichosystem
Labels
dapp dapp related issues/PRs enhancement

Comments

@nichosystem
Copy link
Contributor

nichosystem commented Jan 4, 2023 •
edited
Loading

  • Add ETH and WETH swaps
  • Add FRAX swap
  • Fix ETH not needing approval
  • Rework input component (Can't enter 0 or decimal on input, need to be able to see more numbers)
  • Add a check for single swap instead of batch swap https://github.com/balancer-labs/frontend-v2/blob/870d008f7062e3082cb446c895a8df61f4bab8ba/src/services/swap/swap.service.ts#L64
  • Stylize the crypto selector input dropdown (Add down caret SVG and an outline around the crypto ticker so people know it's clickable)
  • Display error message in TransactionPreviewModal if input value is greater than input token balance
  • Refresh buy/sell quote every 30 seconds in TransactionPreviewModal
  • use-swap-controller handleSell and handleBuy need to display a warning when the price changes and the buy/sell fails
  • Refetch balances on account change
@nichosystem nichosystem self-assigned this Jan 4, 2023
@nichosystem nichosystem added dapp dapp related issues/PRs enhancement labels Jan 4, 2023
@nichosystem nichosystem mentioned this issue Jan 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nichosystem nichosystem

Labels
dapp dapp related issues/PRs enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nichosystem