-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Fix PIR Unittest No.35 BUAA】Fit some test case in PIR #66286
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
file( | ||
GLOB TEST_OPS | ||
RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}" | ||
"test_*.py") | ||
string(REPLACE ".py" "" TEST_OPS "${TEST_OPS}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要提交额外文件,这个文件需要删掉!
@@ -0,0 +1,207 @@ | |||
# Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上!
dtype="float32", | ||
) | ||
|
||
label.desc.set_need_check_feed(False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对于set_need_check_feed的修改方法应该是:
if not paddle.framework.use_pir_api():
label.desc.set_need_check_feed(False)
而不是把整个逻辑都放到if里。
收到,CI已通过,请求merge |
PR Category
Others
PR Types
Others
Description
修复了'paddle.base.libpaddle.pir.Value'没有‘desc’接口导致的报错