Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sparse]optimize sparse convolution and fix MaskHelper bug #47703

Merged
merged 7 commits into from
Nov 9, 2022

Conversation

zkh2016
Copy link
Contributor

@zkh2016 zkh2016 commented Nov 7, 2022

PR types

Performance optimization

PR changes

OPs

Describe

  1. 优化conv性能:
  • 因为table_size太大,导致cudaMemset耗时有点多,table主要是用来判断indices是否存在,因此可以采用bitset来标记,有效减小存储空间,减少cudaMemset耗时。
  • centerpoint推理中:cudaMemset耗时从236ms->23ms,10倍加速比;整体推理性能提升5%。
  • 测试环境:3090, cuda11.6
  1. 修复mask_helper的bug:问题是代码里默认了sparse的维度是x_dims().size()-1,应该改成sparse_dim。

@paddle-bot
Copy link

paddle-bot bot commented Nov 7, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zkh2016 zkh2016 changed the title [Sparse]optimize sparse convolution [WIP]optimize sparse convolution Nov 7, 2022
@zkh2016 zkh2016 changed the title [WIP]optimize sparse convolution [Sparse]optimize sparse convolution Nov 7, 2022
@zkh2016 zkh2016 changed the title [Sparse]optimize sparse convolution [Sparse]optimize sparse convolution and fix bug Nov 8, 2022
@zkh2016 zkh2016 changed the title [Sparse]optimize sparse convolution and fix bug [Sparse]optimize sparse convolution and fix MaskHelper bug Nov 9, 2022
@zkh2016 zkh2016 merged commit 1aa64d1 into PaddlePaddle:develop Nov 9, 2022
zkh2016 pushed a commit to zkh2016/Paddle that referenced this pull request Nov 11, 2022
zkh2016 pushed a commit to zkh2016/Paddle that referenced this pull request Jan 31, 2023
lanxianghit pushed a commit that referenced this pull request Feb 2, 2023
cherry-pick some PR about optimize sparse kernel and fix some bug:
#47736 #47703 #47604 #46679 #48439 #49009 #49734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants