[Sparse]int32/64 does not call backward in elementwise unittest #47604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
veyron95
approved these changes
Nov 3, 2022
zkh2016
pushed a commit
to zkh2016/Paddle
that referenced
this pull request
Jan 31, 2023
lanxianghit
pushed a commit
that referenced
this pull request
Feb 2, 2023
|
修复elementwise_grad的PR：#52102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
当前elementwise反向输出会把0的元素的梯度保留，导致dx.values()的shape可能比x.shape()大，当values类型是int32或int64时，会插入cast操作，反向执行到cast的时候引发bug，该bug在 FLAGS_use_system_allocator=1 时候很容易复现。
当前先在单测中跳过int32或int64的反向计算避免CI挂，下个PR在修改elementwise的反向计算逻辑。