Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade Rust to v1.83 #789

Merged
merged 2 commits into from
Feb 5, 2025
Merged

build: upgrade Rust to v1.83 #789

merged 2 commits into from
Feb 5, 2025

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Feb 5, 2025

Resolves #788

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Feb 5, 2025
@Wodann Wodann requested a review from a team February 5, 2025 20:01
@Wodann Wodann self-assigned this Feb 5, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ece2e61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark February 5, 2025 20:01 — with GitHub Actions Inactive
agostbiro
agostbiro approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@agostbiro
Copy link
Member

Hmm, code looks good, but there is a concerning CI failure with a stack overflow: https://github.com/NomicFoundation/edr/actions/runs/13165579873/job/36745105179?pr=789

@Wodann
Copy link
Member Author

Wodann commented Feb 5, 2025

Hmm, code looks good, but there is a concerning CI failure with a stack overflow: https://github.com/NomicFoundation/edr/actions/runs/13165579873/job/36745105179?pr=789

Looking into it. I forgot but it has to do with this:

This version of Rust rust-lang/rust#131233 that was introduced in 1.81 that broke our usage of native Node modules, inhibiting prior upgrades.

@Wodann Wodann changed the title build: upgrade Rust to v1.81 build: upgrade Rust to v1.83 Feb 5, 2025
@Wodann Wodann temporarily deployed to github-action-benchmark February 5, 2025 20:40 — with GitHub Actions Inactive
@Wodann Wodann added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 41a550a Feb 5, 2025
37 checks passed
@Wodann Wodann deleted the build/rust-1.81 branch February 5, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agostbiro agostbiro agostbiro approved these changes

Assignees

@Wodann Wodann

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Rust to v1.81 (or later)
2 participants
@Wodann @agostbiro