Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to Rust 1.83.0 #757

Merged
merged 2 commits into from
Dec 31, 2024
Merged

build: upgrade to Rust 1.83.0 #757

merged 2 commits into from
Dec 31, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Dec 20, 2024

This version of Rust resolves a bug that was introduced in 1.81 that broke our usage of native Node modules, inhibiting prior upgrades.

This version of Rust resolves a bug that was
introduced in 1.81 that broke our usage of native
Node modules, inhibiting prior upgrades.
@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Dec 20, 2024
@Wodann Wodann requested a review from a team December 20, 2024 11:45
@Wodann Wodann self-assigned this Dec 20, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 682dbc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann had a problem deploying to github-action-benchmark December 20, 2024 11:46 — with GitHub Actions Failure
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.98%. Comparing base (53aa8bf) to head (682dbc5).
Report is 1 commits behind head on feat/multichain.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/multichain     #757      +/-   ##
===================================================
- Coverage            54.21%   53.98%   -0.23%     
===================================================
  Files                  243      243              
  Lines                28342    28142     -200     
  Branches             28342    28142     -200     
===================================================
- Hits                 15365    15192     -173     
- Misses               12050    12060      +10     
+ Partials               927      890      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann had a problem deploying to github-action-benchmark December 20, 2024 12:26 — with GitHub Actions Failure
@agostbiro
Copy link
Member

I reran the benchmark job to see if it was a one-off. The regression on synthetix (the largest benchmark suite) is somewhat concerning.

@Wodann
Copy link
Member Author

Wodann commented Dec 20, 2024

I reran the benchmark job to see if it was a one-off. The regression on synthetix (the largest benchmark suite) is somewhat concerning.

The regression originally happened here in the previous PR.

I still need to investigate why introducing the genesis state introduces the regression, but I expect it either has to do with:

  • Changing the ProviderConfig in that PR changes the executed code
  • The back and forth between Rust and TS introduced additional overhead in construction of the Provider

@Wodann Wodann temporarily deployed to github-action-benchmark December 20, 2024 13:25 — with GitHub Actions Inactive
@Wodann
Copy link
Member Author

Wodann commented Dec 31, 2024

I added a follow-up issue for the performance regression

@Wodann Wodann merged commit 7f21538 into feat/multichain Dec 31, 2024
40 of 41 checks passed
@Wodann Wodann deleted the build/rust-1.83 branch December 31, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants