-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade to Rust 1.83.0 #757
Conversation
This version of Rust resolves a bug that was introduced in 1.81 that broke our usage of native Node modules, inhibiting prior upgrades.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/multichain #757 +/- ##
===================================================
- Coverage 54.21% 53.98% -0.23%
===================================================
Files 243 243
Lines 28342 28142 -200
Branches 28342 28142 -200
===================================================
- Hits 15365 15192 -173
- Misses 12050 12060 +10
+ Partials 927 890 -37 ☔ View full report in Codecov by Sentry. |
I reran the benchmark job to see if it was a one-off. The regression on |
The regression originally happened here in the previous PR. I still need to investigate why introducing the genesis state introduces the regression, but I expect it either has to do with:
|
I added a follow-up issue for the performance regression |
This version of Rust resolves a bug that was introduced in 1.81 that broke our usage of native Node modules, inhibiting prior upgrades.