Revert "CMP-5786 iOS TF2: Implement textFieldMagnifierNode" #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 98e772c.
ASalavei
reviewed
Mar 7, 2025
There was a problem hiding this comment.
@alexzhirkevich, we have to revert it due to https://youtrack.jetbrains.com/issue/CMP-5786/iOS-TF2-Implement-textFieldMagnifierNode#focus=Comments-27-11675902.0-0 .
As far as I know, @mazunin-v-jb is working on the fix.
@mazunin-v-jb , please confirm (or not).
ASalavei
approved these changes
Mar 7, 2025
|
True, this happened due to my mistake, I should have merged my PR with iOS-like caret behavior in BTF2 first. I've asked @alexzhirkevich to re-create PR with implementing magnifier later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1549
Merged too early, should be reverted for now
Release Notes
N/A