-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-5786 iOS TF2: Implement textFieldMagnifierNode #1549
CMP-5786 iOS TF2: Implement textFieldMagnifierNode #1549
Conversation
...kitMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.uikit.kt
Outdated
Show resolved
Hide resolved
...se/foundation/foundation/src/uikitMain/kotlin/androidx/compose/foundation/Magnifier.uikit.kt
Show resolved
Hide resolved
...in/androidx/compose/foundation/text/input/internal/selection/TextFieldMagnifierNode.uikit.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for the MR!
CI checks are not listed here, but I can confirm that they all passed successfully.
cc @igordmn .
You should create |
.../kotlin/androidx/compose/foundation/text/input/internal/selection/TextFieldSelectionState.kt
Show resolved
Hide resolved
...undation/src/commonMain/kotlin/androidx/compose/foundation/text/LongPressTextDragObserver.kt
Outdated
Show resolved
Hide resolved
@igordmn , that what I did: https://github.com/JetBrains/compose-multiplatform-core/tree/pull/1549 |
It was added to the last commit you pushed to that branch. it probably needs to be the last commit of the PR to appear on the PR itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the long review :|
Could you please also rebase onto latest jb-main? After that we can merge it
...se/foundation/foundation/src/uikitMain/kotlin/androidx/compose/foundation/Magnifier.uikit.kt
Outdated
Show resolved
Hide resolved
Thanks a lot! |
This reverts commit 98e772c.
Fixes 5786
Testing
Snippet for testing
This should be tested by QA
upd. removed Release Notes due to reverting this PR (see reasons there)
Release Notes
N/A