[ZEND-552] Remove stale transactions when a hard fork activates #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the cross hard fork checks also to the case of tip disconnection.
The test is creating a shielding transaction around the shielded pool deprecation hard fork, and such transaction wasn't correctly removed in the past after the fork activation.
a-petrini
approved these changes
Aug 24, 2023
titusen
reviewed
Aug 25, 2023
The "listunspent()" RPC command may return outdated results if it's called immediately after the submission of a transaction, as the wallet is notified by a separate thread with some delay.
ptagl
force-pushed
the
gp/post_hard_fork_tx_eviction
branch
from
57add7c to
421686d
Compare
a-petrini
pushed a commit
that referenced
this pull request
Aug 30, 2023
a-petrini
added a commit
that referenced
this pull request
Aug 30, 2023
Python tests of this PR relies on changes introduced in PR #586, which is not included in this release. This commit fixes the issue temporarily.
a-petrini
pushed a commit
that referenced
this pull request
Aug 30, 2023
a-petrini
added a commit
that referenced
this pull request
Aug 30, 2023
Python tests of this PR relies on changes introduced in PR #586, which is not included in this release. This commit fixes the issue temporarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RemoveStaleTransaction()function is currently called every time a block is connected/disconnected to eventually remove transactions that became invalid.To keep the flow as efficient as possible, such function doesn't run all the checks available inside
AcceptTxToMemoryPool()but only the ones that could really fail and depend on the context (like the chain height, or the state of a sidechain).This PR includes a small fix to apply additional checks in case a hard fork activates, because the change in the set of validation rules may affect pending transactions (for instance, a shielding transaction will not be valid anymore after the activation of hard fork #11).