Ap/join network sync improvement zend 616 #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptagl
reviewed
Aug 2, 2023
titusen
approved these changes
Aug 3, 2023
a-petrini
force-pushed
the
ap/join_network_sync_improvement_ZEND-616
branch
from
281ba35 to
d17c746
Compare
JackPiri
reviewed
Aug 7, 2023
JackPiri
reviewed
Aug 7, 2023
JackPiri
reviewed
Aug 7, 2023
JackPiri
reviewed
Aug 7, 2023
JackPiri
reviewed
Aug 7, 2023
JackPiri
approved these changes
Aug 7, 2023
a-petrini
force-pushed
the
ap/join_network_sync_improvement_ZEND-616
branch
2 times, most recently
from
5acd8a5 to
7dda8a4
Compare
drgora
approved these changes
Aug 8, 2023
a-petrini
force-pushed
the
ap/join_network_sync_improvement_ZEND-616
branch
from
f2c361b to
0aad1dc
Compare
All net messages strings / const char* have been replaced with equivalent instances uniquely defined in NetMsgType namespace
This commit adds maps mapSendBytesPerMsgType and mapRecvBytesPerMsgType in CNode class, to keep track of how many messages o f a specific kind and how many bytes for each message type a peer exchanges.
…sage This commit updates getpeerinfo rpc command by adding fields bytessent_per_msg and bytesrecv_per_msg that contains the amount of data (in bytes) exchaned with a peer, divided by message type
This commit changes the logic of Python test framework's connect_nodes() function. It now waits for the two peers to receive the 'verack' version before exiting, preventing race conditions such as two nodes exchanging messages before the actual connection handshake has been completed
a-petrini
force-pushed
the
ap/join_network_sync_improvement_ZEND-616
branch
from
0aad1dc to
c6112c5
Compare
ptagl
approved these changes
Aug 9, 2023
a-petrini
added a commit
that referenced
this pull request
Aug 30, 2023
Python tests of this PR relies on changes introduced in PR #586, which is not included in this release. This commit fixes the issue temporarily.
a-petrini
added a commit
that referenced
this pull request
Aug 30, 2023
Python tests of this PR relies on changes introduced in PR #586, which is not included in this release. This commit fixes the issue temporarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic behind the connection of two zend nodes in the test framework. In particular, we introduced a check that explicitly waits for the two nodes to exchange their respective
verackmessages before continuing with the test. This prevents racing conditions such as requesting data to a node before the connection takes place.For this purpose, we enriched the
getpeerinfo()RPC command with two new fields:bytessent_per_msgandbytesrecv_per_msg, two dictionaries which collect the amount of sent and received data, divided by message category.This PR also modifies a few tests that were sporadically failing because of that racing condition.
Finally, we fixed
mempool_coinbase_spendstest which lacked proper synchronization between the two nodes.