Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(canonical): proper explanation for url misuse #12676

Merged
merged 3 commits into from
Jul 8, 2021
Merged

core(canonical): proper explanation for url misuse #12676

merged 3 commits into from
Jul 8, 2021

Conversation

todortotev
Copy link
Contributor

@todortotev todortotev commented Jun 19, 2021 •
edited by paulirish
Loading

Summary
Modified explanationRelative from Relative URL ({url}) to Is not an absolute URL ({url})

Related Issues/PRs
Fixes #12463
Closes #12479

@todortotev todortotev requested a review from a team as a code owner June 19, 2021 05:15
@todortotev todortotev requested review from adamraine and removed request for a team June 19, 2021 05:15
@google-cla google-cla bot added the cla: yes label Jun 19, 2021
@todortotev todortotev changed the title core(canonical): Proper explanation for url misuse. core(canonical): proper explanation for url misuse. Jun 19, 2021
@todortotev todortotev changed the title core(canonical): proper explanation for url misuse. core(canonical): proper explanation for url misuse Jun 19, 2021
adamraine
adamraine approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to run yarn update:sample-json and commit the changes to pass CI checks.

@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 25, 2021
@paulirish
Copy link
Member

@googlebot I consent

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 25, 2021
@paulirish paulirish mentioned this pull request Jun 25, 2021
Closed
@adamraine adamraine merged commit 000da66 into GoogleChrome:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative canonical reported as invalid
4 participants
@todortotev @paulirish @adamraine @devtools-bot