core(canonical): add 'not recommended' to relative url string #12479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
May 14, 2021
| @@ -32,7 +32,7 @@ const UIStrings = { | |||
| * @description Explanatory message stating that there was a failure in an audit caused by a URL being relative instead of absolute. | |||
| * @example {https://example.com/} url | |||
| * */ | |||
| explanationRelative: 'Relative URL ({url})', | |||
| explanationRelative: 'Relative URL ({url}) (not recommended)', | |||
There was a problem hiding this comment.
Double parenthesis feels weird.
Suggested change
| explanationRelative: 'Relative URL ({url}) (not recommended)', | |
| explanationRelative: 'Relative URL not recommended ({url})', |
connorjclark
changed the title
paulirish
reviewed
May 25, 2021
| @@ -32,7 +32,7 @@ const UIStrings = { | |||
| * @description Explanatory message stating that there was a failure in an audit caused by a URL being relative instead of absolute. | |||
| * @example {https://example.com/} url | |||
| * */ | |||
| explanationRelative: 'Relative URL ({url})', | |||
| explanationRelative: 'Relative URL ({url}) (not recommended)', | |||
There was a problem hiding this comment.
an alternative... we communicate it's not absolute. that's what we want.
Suggested change
| explanationRelative: 'Relative URL ({url}) (not recommended)', | |
| explanationRelative: 'Is not an absolute URL ({url})', |
There was a problem hiding this comment.
#12676 adopted my suggestion, so that works fine for me. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a not recommended flag in relative URLs description.
Related Issues/PRs
Ref #12463