Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] disable test_not_match_service_target #4254

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

genesor
Copy link
Member

@genesor genesor commented Mar 6, 2025

Motivation

First part of the test switch needed to for APMAPI-1005

We need to disable test_not_match_service_target so the CI is green on dd-trace-go/3261 and then enable the new test TestDynamicConfigV1_EmptyServiceTargets after the merge.

Changes

  • Mark test_not_match_service_target as irrelevant

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@genesor genesor marked this pull request as ready for review March 6, 2025 11:07
@genesor genesor requested review from mabdinur and a team as code owners March 6, 2025 11:07
@genesor genesor merged commit 59cf29b into main Mar 6, 2025
33 checks passed
@genesor genesor deleted the ben.db/APMAPI-1005-disable-go-rc-system-test branch March 6, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants