ddtrace/tracer: remove remote config check on env and service name #3261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Per APMAPI-1003 the remote config clients should now trust that the configurations they receive belong to them.
Motivation
With Adaptive Sampling, the Go tracer is rejecting remote sampling rules that use SSI when the tracer sees that the values of DD_ENV are empty. However, the env is automatically configured in the agent with SSI, so this PR removes all filtering of DD_SERVICE and DD_ENV in the tracer as it is already being done in remote config.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!