Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: remove remote config check on env and service name #3261

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

genesor
Copy link
Member

@genesor genesor commented Mar 5, 2025

What does this PR do?

Per APMAPI-1003 the remote config clients should now trust that the configurations they receive belong to them.

Motivation

With Adaptive Sampling, the Go tracer is rejecting remote sampling rules that use SSI when the tracer sees that the values of DD_ENV are empty. However, the env is automatically configured in the agent with SSI, so this PR removes all filtering of DD_SERVICE and DD_ENV in the tracer as it is already being done in remote config.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@genesor genesor requested a review from a team as a code owner March 5, 2025 15:44
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: ben.db/APMAPI-1005-remove-matching-rc-check
Commit report: 2268e75
Test service: dd-trace-go

✅ 0 Failed, 5387 Passed, 72 Skipped, 3m 6.8s Total Time

@genesor genesor requested a review from a team as a code owner March 6, 2025 10:38
@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-06 11:05:49

Comparing candidate commit 4bc778b in PR branch ben.db/APMAPI-1005-remove-matching-rc-check with baseline commit 18fec70 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants