Remove python_minimal interface #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message provides migration information.
Switch to prefer the shorter 'y' and 'n' strings to configure the Python package, rather than 'full' and 'none'. Since we no longer need 'minimal' anymore, we can simplify this.
Simplify configuration of the Python package and move the config checking to a separate function in buildutils.py.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 381 381
Lines 54164 54164
Branches 9240 9240
=======================================
Hits 39562 39562
Misses 11633 11633
Partials 2969 2969 ☔ View full report in Codecov by Sentry. |
ischoegl
previously approved these changes
Jul 30, 2024
ischoegl
reviewed
Jul 30, 2024
ischoegl
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
python_minimalinterfacesetup.cfg.infile. Requires thepackagingpackage;pkg_resourcesis deprecated anyways.If applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#208
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage