Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the python_minimal interface #208

Closed
bryanwweber opened this issue Jul 28, 2024 · 0 comments · Fixed by Cantera/cantera#1745
Closed

Remove the python_minimal interface #208

bryanwweber opened this issue Jul 28, 2024 · 0 comments · Fixed by Cantera/cantera#1745
Assignees
Labels
feature-request New feature request

Comments

@bryanwweber
Copy link
Member

Abstract

The python_minimal interface exists to provide copies of just the conversion scripts (ck2yaml et al.). We do not distribute the interface, and building and installing the full Python interface is much simpler now than when the minimal interface was added. I believe we can remove the minimal interface to save some complexity in the SCons configuration and the source tree.

Motivation

In the past, installing the dependencies to build the full Python/Cython interface to Cantera was somewhat difficult, particularly on Windows. It generally required visiting Cristoph Gohlke's site to download appropriate platform binaries for dependencies, the PyPI ecosystem was much less developed, and conda didn't exist.

Since that time, all of these problems have been resolved, and Cristoph even took his site down! As such, I believe we can reduce the complexity of SCons configuration by removing the option for a "minimal" interface build. Specifically, we could remove the numerous checks when python_package is left as the default and the complicated conditionals to decide if the "minimal" package can be built instead of the full.

The only downside that I can see of full removing the minimal interface is that users who are only interested in C/C++/Fortran interfaces to Cantera will need to build the full Python interface to access conversion scripts. However, I believe we provide enough installation options for just the Python interface (PyPI, conda) and as mentioned previously, building the Python interface is as easy as the other interfaces these days. So I don't think this is a big downside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant