Implement remaining script API commands #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The test only verifies that the "SCRIPT KILL" command is sent to a live Redis environment by sending a command when no script is running and tests for an "NOTBUSY" error. Currently it does not test for a successfully stopped long-running script.
|
Hello, you can try to check ideas from previous try of implementation of this commands. May be that can help you |
| @@ -179,6 +188,28 @@ trait ScriptingSpec extends BaseSpec { | |||
| sha <- scriptLoad(lua).either | |||
| } yield assert(sha)(isLeft(isSubtype[ProtocolError](hasField("message", _.message, equalTo(error))))) | |||
| } | |||
| ), | |||
| suite("scriptFlush")( | |||
| test("return true if loaded scripts are flushed from the cache") { | |||
There was a problem hiding this comment.
I think here need check that scripts exists before flush
| } yield assertTrue(res == Chunk(false, false)) | ||
| } | ||
| ), | ||
| suite("scriptKill")( |
There was a problem hiding this comment.
There are no success test(
|
Thanks for the review, I checked the linked PR and I tried to perform the same test as you did (infinite loop in Lua and test for |
|
Implemented in #750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses remaining items in #158.
Please check if tests for these commands are satisfactory, I could only come up with a basic test for
scriptDebug, and forscriptKillI couldn't figure out how to fork a long-running script (e.g., infinite loop) and attempt to kill it.