Redis Service #552
Merged
Redis Service #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatolysergeev
force-pushed
the
improvement-sugesstions
branch
from
712f0c6 to
55bfb99
Compare
mijicd
requested changes
Feb 20, 2022
| @@ -39,6 +39,7 @@ package object redis | |||
| with options.Scripting { | |||
|
|
|||
| type Id[+A] = A | |||
| type Redis = Has[Redis.Service] | |||
There was a problem hiding this comment.
Let's start moving towards the new module encoding. This assumes the following:
- remove the type aliases like this
- extract the
Services to top-level traits - propagate
There was a problem hiding this comment.
Hope, I did it as you meant, didn't i?)
all redis commands depend on redis service remove redis executor dependency from codec
anatolysergeev
force-pushed
the
improvement-sugesstions
branch
from
55bfb99 to
915a517
Compare
mijicd
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add redis service that include codec and executor
all redis commands depend on redis service
remove redis executor dependency on codec