Implement keys API in test executor #194 #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
reviewed
Nov 9, 2021
| @@ -650,6 +660,193 @@ private[redis] final class TestExecutor private ( | |||
| ) | |||
| } | |||
|
|
|||
| case api.Keys.Exists | api.Keys.Touch => | |||
| val allkeys = input.map(_.asString) | |||
There was a problem hiding this comment.
This can be part of fold, e.g.:
STM.foldLefft(input)(0L) { case (acc, key) =>
// key.asString
}This pattern is repeated a few times so please adjust all occurrences.
| val options = input.drop(1).map(_.asString) | ||
|
|
||
| val countIndex = options.indexOf("COUNT") | ||
| val count = Option.when(countIndex >= 0)(options(countIndex + 1).toInt) |
There was a problem hiding this comment.
I think that Option.when won't work in 2.12.
|
|
||
| case api.Keys.Expire => | ||
| val key = input(0).asString | ||
| val unixtime = now.plusSeconds(input(1).asLong) |
There was a problem hiding this comment.
This should be suspended, but since we don't have a proper solution for clock in stm, it can stay.
Comment on lines
1567
to
1568
| _ <- if (newHash.isEmpty) delete(key) | ||
| else putHash(key, newHash) |
There was a problem hiding this comment.
You should be able to use ZIO.cond for all similar occurrences.
Comment on lines
3206
to
3208
| case class KeyInfo(`type`: KeyType, expireAt: Option[Instant]) { | ||
| lazy val redisType: RedisType = KeyType.toRedisType(`type`) | ||
| } |
fix compilation errors for scala 2.12
mijicd
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continuation of PR #371
Some changes in the concept how we save expiration time, before there was an idea to have two separated stores for keys and expiration time, I do not very like that idea because it doesn't have good scale options. I decided to unite them in one key store where we save all information about our key: type, expiration time, etc.