fix: detect if relation is oneToOne #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/one-to-one
branch
from
42e31c4 to
559f8d9
Compare
nikophil
force-pushed
the
fix/one-to-one
branch
from
559f8d9 to
7259958
Compare
nikophil
commented
Dec 6, 2024
| @@ -29,17 +29,18 @@ public function relationshipMetadata(string $parent, string $child, string $fiel | |||
| { | |||
| $metadata = $this->classMetadata($parent); | |||
|
|
|||
| $association = $this->getAssociationMapping($parent, $field); | |||
| $association = $this->getAssociationMapping($parent, $child, $field); | |||
There was a problem hiding this comment.
I think that at some point I'll refacto this method which is becoming ugly
kbond
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a last bug before we can release 2.3: some edge case was buggy, when the a many to one was referencing a "self referencing" class