fix: can create inversed one to one with non nullable

src/Persistence/PersistentObjectFactory.php

@@ -22,6 +22,8 @@
 use Zenstruck\Foundry\Persistence\Exception\NotEnoughObjects;
 use Zenstruck\Foundry\Persistence\Exception\RefreshObjectFailed;
 
+use function Zenstruck\Foundry\get;
+
 /**
  * @author Kevin Bond <[email protected]>
  *
@@ -271,13 +273,23 @@ protected function normalizeParameter(string $field, mixed $value): mixed
 
             // handle inversed OneToOne
             if ($relationshipMetadata && !$relationshipMetadata->isCollection && $inverseField = $relationshipMetadata->inverseField) {
-                $this->tempAfterPersist[] = static function(object $object) use ($value, $inverseField, $pm) {
+                // we create now the object to prevent "non-nullable" property errors,
+                // but we'll need to remove it once the current object is created
+                $inversedObject = unproxy($value->create());
+                $this->tempAfterPersist[] = static function(object $object) use ($value, $inverseField, $pm, $inversedObject) {
+                    // we cannot use the already created $inversedObject:
+                    // because we must also remove its potential newly created owner (here: "$oldObj")
+                    // but a cascade:["persist"] would remove too many things
                     $value->create([$inverseField => $object]);
                     $pm->refresh($object);
+                    $oldObj = get($inversedObject, $inverseField);
+                    delete($inversedObject);
+                    if ($oldObj) {
+                        delete($oldObj); // @phpstan-ignore argument.templateType
+                    }
                 };
 
-                // creation delegated to afterPersist hook - return empty array here
-                return null;
+                return $inversedObject;
             }
 
             if (Configuration::instance()->persistence()->relationshipMetadata(static::class(), $value::class(), $field)?->isCascadePersist) {

tests/Fixture/Entity/EdgeCases/InversedOneToOneWithNonNullableOwning/InverseSide.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Zenstruck\Foundry\Tests\Fixture\Entity\EdgeCases\InversedOneToOneWithNonNullableOwning;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @author Nicolas PHILIPPE <[email protected]>
+ */
+#[ORM\Entity]
+class InverseSide
+{
+    #[ORM\Id]
+    #[ORM\Column]
+    #[ORM\GeneratedValue(strategy: 'AUTO')]
+    public ?int $id = null;
+
+    public function __construct(
+        #[ORM\OneToOne(mappedBy: 'inverseSide')]
+        public OwningSide $owningSide
+    ) {}
+}

tests/Fixture/Entity/EdgeCases/InversedOneToOneWithNonNullableOwning/OwningSide.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Zenstruck\Foundry\Tests\Fixture\Entity\EdgeCases\InversedOneToOneWithNonNullableOwning;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @author Nicolas PHILIPPE <[email protected]>
+ */
+#[ORM\Entity]
+class OwningSide
+{
+    #[ORM\Id]
+    #[ORM\Column]
+    #[ORM\GeneratedValue(strategy: 'AUTO')]
+    public ?int $id = null;
+
+    #[ORM\OneToOne(inversedBy: 'owningSide')]
+    public InverseSide|null $inverseSide = null;
+}

tests/Integration/ORM/EdgeCasesRelationshipTest.php

@@ -13,6 +13,7 @@
 
 namespace Zenstruck\Foundry\Tests\Integration\ORM;
 
+use Zenstruck\Foundry\Tests\Fixture\Entity\EdgeCases\InversedOneToOneWithNonNullableOwning;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Persistence\PersistentObjectFactory;
 use Zenstruck\Foundry\Persistence\Proxy;
@@ -25,6 +26,7 @@
 use Zenstruck\Foundry\Tests\Fixture\Stories\GlobalStory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
+use function Zenstruck\Foundry\factory;
 use function Zenstruck\Foundry\Persistence\flush_after;
 use function Zenstruck\Foundry\Persistence\persistent_factory;
 use function Zenstruck\Foundry\Persistence\proxy_factory;
@@ -106,6 +108,22 @@ public static function richDomainMandatoryRelationshipFactoryProvider(): iterabl
         ];
     }
 
+    /**
+     * @test
+     */
+    public function inverse_one_to_one_with_non_nullable_inverse_side(): void
+    {
+        $owningSideFactory = persistent_factory(InversedOneToOneWithNonNullableOwning\OwningSide::class);
+        $inverseSideFactory = persistent_factory(InversedOneToOneWithNonNullableOwning\InverseSide::class);
+
+        $inverseSide = $inverseSideFactory->create(['owningSide' => $owningSideFactory]);
+
+        $owningSideFactory::assert()->count(1);
+        $inverseSideFactory::assert()->count(1);
+
+        self::assertSame($inverseSide, $inverseSide->owningSide->inverseSide);
+    }
+
     /**
      * @test
      */