Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update #594

Merged
merged 2 commits into from
Jun 7, 2024
Merged

doc: update #594

merged 2 commits into from
Jun 7, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Apr 20, 2024

EDIT (from @nikophil)

I think the doc on symfony.com is updated as soon as the doc is modified (disregarding releases). So, here is the plan for 2.x:

  • finish and validate this PR without merging it
  • once validated, copy this PR into another which will target 2.x and add missing pieces
  • merge both doc PR + release both 1.x and 2.x 🚀

todo for 2.x documentation:

  • document ArrayFactory
  • document __index for factory collections this was already documented
  • make:factories: document --with-phpdoc option and add change the note about @method
  • remove documentation of the config auto_refresh_proxies

@nikophil
Copy link
Member

nikophil commented May 1, 2024

something else: WDYT about documenting this little, but still useful, behavior (the stuff with __index)?

@nikophil nikophil marked this pull request as ready for review June 3, 2024 09:11
Copy link
Member Author

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @nikophil!

Your plan for syncing this with 2.x makes sense. We'll need to update https://github.com/zenstruck/foundry/blob/1.x/.symfony.bundle.yaml (probably on 1.x and 2.x)

@kbond kbond merged commit 691741f into zenstruck:1.x Jun 7, 2024
19 checks passed
@kbond kbond deleted the doc-updates branch June 7, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants