Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can use ObjectFactories as service #585

Merged

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Apr 4, 2024

fixes #582

ping @jrushlow

(rector failure is not related, will be fixed in #586)

@nikophil nikophil force-pushed the fix/can-use-object-factories-as-service branch 4 times, most recently from 3746077 to 279c1de Compare April 4, 2024 07:30
@nikophil nikophil force-pushed the fix/can-use-object-factories-as-service branch from 279c1de to 5e786f2 Compare April 4, 2024 11:08
@nikophil nikophil merged commit afad017 into zenstruck:1.x Apr 4, 2024
20 of 21 checks passed
@nikophil nikophil deleted the fix/can-use-object-factories-as-service branch April 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[1.x] [upgrade] ModelFactory to ObjectFactory with services throws \RuntimeException
1 participant