fix(sca): fix type system with legacy FactoryCollection #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
refactor/factory-collection
branch
3 times, most recently
from
fb8e162 to
15fd4ab
Compare
nikophil
force-pushed
the
refactor/factory-collection
branch
from
15fd4ab to
1c5958c
Compare
nikophil
force-pushed
the
refactor/factory-collection
branch
from
1c5958c to
9479644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit upset that the upgade to 1.x-bc would potentially break static analysis i userland: on my main project, it was creating ~50 failures - all more or less related to
FactoryCollection. This PR fixes them all 😁 `