Doesn't work with a release built yk

[vext01]

$ make  YK_BUILD_TYPE=release
...
$ ./src/lua tests/tpack.lua
testing pack/unpack
platform:
        short 2, int 4, long 8, size_t 8, float 4, double 8,
        lua Integer 8, lua Number 8
        little endian
        alignment: 8
testing invalid formats
testing pack/unpack of floating-point numbers
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
testing pack/unpack of strings
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
testing alignment
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', yktrace/src/hwt/mapper.rs:108:87
OK

[vext01]

(works ok with a debug yk)

[vext01]

(works ok with a debug yk)

I was wrong. As soon as I set YKD_SERIALISE_COMPILATION=1 I see the same in debug mode. Investigating...

[vext01]

The failures are to do with the static and inline keywords interfering with symbol visibility.

I got it working with the following hacks (from Lukas):

diff --git a/src/lapi.c b/src/lapi.c
index 5ee6579..d1ec425 100644
--- a/src/lapi.c
+++ b/src/lapi.c
@@ -57,7 +57,7 @@ const char lua_ident[] =
 ** Convert an acceptable index to a pointer to its respective value.
 ** Non-valid indices return the special nil value 'G(L)->nilvalue'.
 */
-static TValue *index2value (lua_State *L, int idx) {
+TValue *index2value (lua_State *L, int idx) {
   CallInfo *ci = L->ci;
   if (idx > 0) {
     StkId o = ci->func + idx;
diff --git a/src/lauxlib.c b/src/lauxlib.c
index 8ed1da1..3d79fcc 100644
--- a/src/lauxlib.c
+++ b/src/lauxlib.c
@@ -543,7 +543,7 @@ static size_t newbuffsize (luaL_Buffer *B, size_t sz) {
 ** 'B'. 'boxidx' is the relative position in the stack where is the
 ** buffer's box or its placeholder.
 */
-static char *prepbuffsize (luaL_Buffer *B, size_t sz, int boxidx) {
+char *prepbuffsize (luaL_Buffer *B, size_t sz, int boxidx) {
   checkbufferlevel(B, boxidx);
   if (B->size - B->n >= sz)  /* enough space? */
     return B->b + B->n;
@@ -1008,7 +1008,7 @@ LUALIB_API const char *luaL_gsub (lua_State *L, const char *s,
 }
 
 
-static void *l_alloc (void *ud, void *ptr, size_t osize, size_t nsize) {
+void *l_alloc (void *ud, void *ptr, size_t osize, size_t nsize) {
   (void)ud; (void)osize;  /* not used */
   if (nsize == 0) {
     free(ptr);
diff --git a/src/lbaselib.c b/src/lbaselib.c
index 1d60c9d..71d9881 100644
--- a/src/lbaselib.c
+++ b/src/lbaselib.c
@@ -422,7 +422,7 @@ static int luaB_dofile (lua_State *L) {
 }
 
 
-static int luaB_assert (lua_State *L) {
+int luaB_assert (lua_State *L) {
   if (l_likely(lua_toboolean(L, 1)))  /* condition is true? */
     return lua_gettop(L);  /* return all arguments */
   else {  /* error */
diff --git a/src/ldo.c b/src/ldo.c
index a48e35f..3a2ae16 100644
--- a/src/ldo.c
+++ b/src/ldo.c
@@ -476,7 +476,7 @@ void luaD_poscall (lua_State *L, CallInfo *ci, int nres) {
 #define next_ci(L)  (L->ci->next ? L->ci->next : luaE_extendCI(L))
 
 
-l_sinline CallInfo *prepCallInfo (lua_State *L, StkId func, int nret,
+/*l_sinline*/ CallInfo *prepCallInfo (lua_State *L, StkId func, int nret,
                                                 int mask, StkId top) {
   CallInfo *ci = L->ci = next_ci(L);  /* new frame */
   ci->func = func;
@@ -490,7 +490,7 @@ l_sinline CallInfo *prepCallInfo (lua_State *L, StkId func, int nret,
 /*
 ** precall for C functions
 */
-l_sinline int precallC (lua_State *L, StkId func, int nresults,
+/*l_sinline*/ int precallC (lua_State *L, StkId func, int nresults,
                                             lua_CFunction f) {
   int n;  /* number of returns */
   CallInfo *ci;
diff --git a/src/llimits.h b/src/llimits.h
index 52a32f9..2622261 100644
--- a/src/llimits.h
+++ b/src/llimits.h
@@ -176,7 +176,7 @@ typedef LUAI_UACINT l_uacInt;
 #define l_inline	/* empty */
 #endif
 
-#define l_sinline	static l_inline
+#define l_sinline	/*l_inline*/
 
 
 /*
diff --git a/src/lstring.c b/src/lstring.c
index 13dcaf4..41333bb 100644
--- a/src/lstring.c
+++ b/src/lstring.c
@@ -140,7 +140,7 @@ void luaS_init (lua_State *L) {
 /*
 ** creates a new string object
 */
-static TString *createstrobj (lua_State *L, size_t l, int tag, unsigned int h) {
+TString *createstrobj (lua_State *L, size_t l, int tag, unsigned int h) {
   TString *ts;
   GCObject *o;
   size_t totalsize;  /* total size of TString object */
@@ -185,7 +185,7 @@ static void growstrtab (lua_State *L, stringtable *tb) {
 /*
 ** Checks whether short string exists and reuses it or creates a new one.
 */
-static TString *internshrstr (lua_State *L, const char *str, size_t l) {
+TString *internshrstr (lua_State *L, const char *str, size_t l) {
   TString *ts;
   global_State *g = G(L);
   stringtable *tb = &g->strt;
diff --git a/src/lstrlib.c b/src/lstrlib.c
index 0b4fdbb..aa14817 100644
--- a/src/lstrlib.c
+++ b/src/lstrlib.c
@@ -147,7 +147,7 @@ static int str_upper (lua_State *L) {
 }
 
 
-static int str_rep (lua_State *L) {
+int str_rep (lua_State *L) {
   size_t l, lsep;
   const char *s = luaL_checklstring(L, 1, &l);
   lua_Integer n = luaL_checkinteger(L, 2);
diff --git a/src/luaconf.h b/src/luaconf.h
index d42d14b..be94ffb 100644
--- a/src/luaconf.h
+++ b/src/luaconf.h
@@ -11,6 +11,7 @@
 #include <limits.h>
 #include <stddef.h>
 
+#define static
 
 /*
 ** ===================================================================
@@ -307,7 +308,7 @@
 */
 #if defined(__GNUC__) && ((__GNUC__*100 + __GNUC_MINOR__) >= 302) && \
     defined(__ELF__)		/* { */
-#define LUAI_FUNC	__attribute__((visibility("internal"))) extern
+#define LUAI_FUNC	/*__attribute__((visibility("internal")))*/ extern
 #else				/* }{ */
 #define LUAI_FUNC	extern
 #endif				/* } */

We should think about better ways of doing this. #define static is scary, since static has several meanings in C, and we only want to nullify it for function defs.

Perhaps we should nullify static and inline when applied to functions, in ykllvm, behind a gate.

[ltratt]

I also needed to use the patch above to get yklua working.

[vext01]

#8 solves most of this.

Only __attribute__((visibility("internal"))) remains an issue.

[vext01]

Closing in favour of ykjit/yk#659