Skip to content
This repository was archived by the owner on Mar 26, 2018. It is now read-only.

Gulp support #127

Closed
wants to merge 1 commit into from
Closed

Gulp support #127

wants to merge 1 commit into from

Conversation

robdodson
Copy link
Contributor

This is a work in progress and not ready to be merged just yet :)

  • Ruby SASS processed for app styles
  • Ruby SASS processed for element styles
  • LibSASS processed for element styles
  • Vanilla CSS processed for app styles
  • Vanilla CSS processed for element styles
  • Verify JSHint is working
  • Verify image processing is working
  • Verify fonts are being copied properly
  • Verify build paths in HTML are being rewritten
  • Verify vulcanize works properly for Ruby SASS projects
  • Verify vulcanize works properly for LibSASS projects
  • Verify vulcanize works properly for CSS projects
  • Verify serve works properly for LibSASS projects
  • Verify serve works properly for Ruby SASS projects
  • Verify serve works properly for CSS projects
  • Verify serve:dist works properly for LibSASS projects
  • Verify serve:dist works properly for Ruby SASS projects
  • Verify serve:dist works properly for CSS projects
  • Verify pagespeed is working
  • Verify autoprefixr works for CSS
  • Verify autoprefixr works for Ruby SCSS
  • Verify autoprefixr works for LibSCSS
  • Figure out if it's possible to merge the styles and elements task
  • Grunt projects are still generated OK :)

@hemanth
Copy link
Member

hemanth commented Jan 22, 2015

WOW! Nice list :) Especially the last one heh heh

@robdodson
Copy link
Contributor Author

Hah yeah :D

Most of the list I think is already done, I'm just double checking it an making some final decisions. I'd love reviewers when it's wrapped up as I'm still a bit of a gulp newb

@ragingwind
Copy link
Contributor

Great. I think I can help you as much as I know.

@amannn
Copy link

amannn commented Feb 2, 2015

Great stuff! But I'd be careful about LibSASS these days. I recently switched to Ruby SASS, since LibSASS isn't able to compile /deep/ selectors (see the issue here).

@robdodson
Copy link
Contributor Author

@amannn thanks for the heads up on LibSass. I may remove the option for libsass until that bug is fixed.

@JosefJezek
Copy link

Also CSSO isn't able to compile /deep/ selectors

css/csso#209

@robdodson
Copy link
Contributor Author

OK, I think I've addressed all the major issues. @addyosmani @sindresorhus if either of you have time to review this before I merge I would be most appreciative. The one thing I was not able to figure out was how to merge the styles and elements tasks into a single task. Every time I tried, I ended up spraying the files into the same directories :\


// Run PageSpeed Insights
// Update `url` below to the public URL for your site
gulp.task('pagespeed', pagespeed.bind(null, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should mostly be able to steal the above code snippet from our changes.

@sindresorhus
Copy link
Member

Just looking at the diff, lgtm.

@sindresorhus
Copy link
Member

@JosefJezek We're using clean-css, not CSSO.

@addyosmani
Copy link
Member

@JosefJezek In Blink/Chrome, there are conversations on-going about whether or not we're going to keep /deep/ around at all. Whilst this is needed for Polymer 0.5, I wouldn't gate landing this on that as 0.8 is likely to use it's own theming system based on mixins and props.

@robdodson We'll review again post the PSI changes.

@robdodson
Copy link
Contributor Author

Closed via 5011f42

@robdodson robdodson closed this Feb 6, 2015
@robdodson robdodson mentioned this pull request Mar 5, 2015
@kevva kevva mentioned this pull request Jun 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants