Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drain api as past of cms api dragt #15474

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

  • Specifially TabletDrainAction - if session drain api becomes a thing, it would be a separate SessionDrainAction
  • drain_action and permanent_drain_action differ in sown (aka cross) policy - drain_action keeps it until restart, permanent_drain_action keeps it permanent
  • However dropping a task with a drain action should cancel the drain if it's still running AND mark the node as Up

Copy link

github-actions bot commented Mar 7, 2025

🟢 2025-03-07 15:14:21 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 15:16:50 UTC Pre-commit check linux-x86_64-release-asan for 645eece has started.
2025-03-07 15:17:05 UTC Artifacts will be uploaded here
2025-03-07 15:20:11 UTC ya make is running...
🟡 2025-03-07 17:04:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14281 14077 0 151 19 34

2025-03-07 17:06:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 17:20:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
253 (only retried tests) 216 0 5 0 32

2025-03-07 17:20:53 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 17:33:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 36 0 0 0 31

🟢 2025-03-07 17:33:25 UTC Build successful.
🟢 2025-03-07 17:33:54 UTC ydbd size 3.7 GiB changed* by +54.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ebdb754 merge: 645eece diff diff %
ydbd size 3 996 097 656 Bytes 3 996 153 168 Bytes +54.2 KiB +0.001%
ydbd stripped size 1 389 147 400 Bytes 1 389 167 016 Bytes +19.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 15:16:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 645eece has started.
2025-03-07 15:17:05 UTC Artifacts will be uploaded here
2025-03-07 15:20:17 UTC ya make is running...
🟡 2025-03-07 16:50:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28690 26093 0 2 2478 117

2025-03-07 16:52:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 17:08:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 68 0 0 0 109

🟢 2025-03-07 17:08:48 UTC Build successful.
🟢 2025-03-07 17:09:10 UTC ydbd size 2.1 GiB changed* by +19.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ebdb754 merge: 645eece diff diff %
ydbd size 2 294 622 192 Bytes 2 294 641 944 Bytes +19.3 KiB +0.001%
ydbd stripped size 480 593 376 Bytes 480 597 216 Bytes +3.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant