Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of important bugfixes for PQ read proxy & kafka proxy #15458

Open
wants to merge 3 commits into
base: stable-25-1
Choose a base branch
from

Conversation

FloatingCrowbar
Copy link
Collaborator

@FloatingCrowbar FloatingCrowbar commented Mar 7, 2025

Changelog entry

Merge of important bugfixes for PQ read proxy & kafka proxy

Changelog category

  • Bugfix

Description for reviewers

The counter value for UserInfo is leaking (#15233)
Fix the bug on pipe failure in read proxy (#15439)
Fix proxy crash on duplicate topics in request (#15467)

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner March 7, 2025 11:46
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 11:48:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9386630 has started.
2025-03-07 11:48:39 UTC Artifacts will be uploaded here
2025-03-07 11:52:02 UTC ya make is running...
🟡 2025-03-07 12:50:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19140 17780 0 5 1214 141

2025-03-07 12:51:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 13:17:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 74 0 0 1 132

🟢 2025-03-07 13:18:06 UTC Build successful.
🟢 2025-03-07 13:18:27 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 97bd83c merge: 9386630 diff diff %
ydbd size 2 242 294 464 Bytes 2 242 294 464 Bytes 0 Bytes 0.000%
ydbd stripped size 474 900 792 Bytes 474 900 792 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 11:50:25 UTC Pre-commit check linux-x86_64-release-asan for 9386630 has started.
2025-03-07 11:50:38 UTC Artifacts will be uploaded here
2025-03-07 11:53:43 UTC ya make is running...
🟡 2025-03-07 13:04:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11811 11732 0 35 4 40

2025-03-07 13:05:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 13:27:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 93 0 0 1 36

🟢 2025-03-07 13:27:52 UTC Build successful.
🟢 2025-03-07 13:28:21 UTC ydbd size 3.6 GiB changed* by -112 Bytes, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 97bd83c merge: 9386630 diff diff %
ydbd size 3 900 523 008 Bytes 3 900 522 896 Bytes -112 Bytes -0.000%
ydbd stripped size 1 365 157 264 Bytes 1 365 157 200 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Mar 7, 2025
@FloatingCrowbar FloatingCrowbar changed the title Merge bugfixes in PQ read proxy Merge of important bugfixes for PQ read proxy & kafka proxy Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 15:53:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 980e19a has started.
2025-03-07 15:54:06 UTC Artifacts will be uploaded here
2025-03-07 15:56:55 UTC ya make is running...
🟡 2025-03-07 17:03:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19166 17642 0 5 1441 78

2025-03-07 17:05:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 17:26:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
377 (only retried tests) 239 0 1 7 130

2025-03-07 17:26:36 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 17:47:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 64 0 0 0 129

🟢 2025-03-07 17:47:28 UTC Build successful.
🟢 2025-03-07 17:47:50 UTC ydbd size 2.1 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 18e5a12 merge: 980e19a diff diff %
ydbd size 2 242 350 792 Bytes 2 242 353 088 Bytes +2.2 KiB +0.000%
ydbd stripped size 474 913 912 Bytes 474 914 360 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 15:55:39 UTC Pre-commit check linux-x86_64-release-asan for 980e19a has started.
2025-03-07 15:55:52 UTC Artifacts will be uploaded here
2025-03-07 15:58:42 UTC ya make is running...
🟡 2025-03-07 17:05:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11837 11756 0 29 11 41

2025-03-07 17:07:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 17:29:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
120 (only retried tests) 85 0 0 0 35

🟢 2025-03-07 17:29:31 UTC Build successful.
🟢 2025-03-07 17:29:56 UTC ydbd size 3.6 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 18e5a12 merge: 980e19a diff diff %
ydbd size 3 900 617 800 Bytes 3 900 621 904 Bytes +4.0 KiB +0.000%
ydbd stripped size 1 365 187 152 Bytes 1 365 188 368 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants