Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of important bugfixes for PQ read proxy & kafka proxy #15457

Open
wants to merge 2 commits into
base: stable-24-4
Choose a base branch
from

Conversation

FloatingCrowbar
Copy link
Collaborator

@FloatingCrowbar FloatingCrowbar commented Mar 7, 2025

Changelog entry

Merge of important bugfixes for PQ read proxy & kafka proxy

Changelog category

  • Bugfix

Description for reviewers

The counter value for UserInfo is leaking (#15233)
Fix proxy crash on duplicate topics in request #15467

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner March 7, 2025 11:43
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 11:47:02 UTC Pre-commit check for aa3477c has started.
2025-03-07 11:49:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-07 12:27:52 UTC Build successful.
2025-03-07 12:28:06 UTC Tests are running...
🔴 2025-03-07 14:02:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14790 13428 0 23 1301 38

🟢 2025-03-07 14:03:02 UTC ydbd size 8.3 GiB changed* by -48 Bytes, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: e524a8e merge: aa3477c diff diff %
ydbd size 8 898 088 400 Bytes 8 898 088 352 Bytes -48 Bytes -0.000%
ydbd stripped size 485 021 032 Bytes 485 021 032 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 11:47:35 UTC Pre-commit check for aa3477c has started.
2025-03-07 11:50:16 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-07 12:14:06 UTC Build successful.
2025-03-07 12:14:28 UTC Tests are running...
🔴 2025-03-07 14:26:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10357 10255 0 32 26 44

🟢 2025-03-07 14:27:36 UTC ydbd size 5.6 GiB changed* by -48 Bytes, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: e524a8e merge: aa3477c diff diff %
ydbd size 6 027 382 312 Bytes 6 027 382 264 Bytes -48 Bytes -0.000%
ydbd stripped size 1 508 393 120 Bytes 1 508 393 120 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 15:51:21 UTC Pre-commit check for 0789c57 has started.
2025-03-07 15:53:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-07 16:35:39 UTC Build successful.
2025-03-07 16:35:53 UTC Tests are running...
🔴 2025-03-07 18:02:39 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14807 13449 0 19 1301 38

🟢 2025-03-07 18:05:02 UTC ydbd size 8.3 GiB changed* by +24.6 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 5a0f4ed merge: 0789c57 diff diff %
ydbd size 8 898 091 192 Bytes 8 898 116 368 Bytes +24.6 KiB +0.000%
ydbd stripped size 485 021 224 Bytes 485 021 608 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 15:52:10 UTC Pre-commit check for 0789c57 has started.
2025-03-07 15:54:54 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-07 16:19:41 UTC Build successful.
2025-03-07 16:20:00 UTC Tests are running...
🔴 2025-03-07 18:43:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10386 10259 0 54 28 45

🟢 2025-03-07 18:44:26 UTC ydbd size 5.6 GiB changed* by +9.9 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 5a0f4ed merge: 0789c57 diff diff %
ydbd size 6 027 385 560 Bytes 6 027 395 656 Bytes +9.9 KiB +0.000%
ydbd stripped size 1 508 393 568 Bytes 1 508 395 104 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@FloatingCrowbar FloatingCrowbar changed the title The counter value for UserInfo is leaking (#15233) Merge of important bugfixes for PQ read proxy & kafka proxy Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants