Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalDB: add waiting for borrow parts returning in DataCleanup logic #15451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lex007in
Copy link
Collaborator

@lex007in lex007in commented Mar 7, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Add waiting for borrowed parts to be returned after compaction, but before first snapshot. So, all returned parts can be garbage collected.

Copy link

github-actions bot commented Mar 7, 2025

🟢 2025-03-07 12:48:29 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 09:50:34 UTC Pre-commit check linux-x86_64-release-asan for a71b5d4 has started.
2025-03-07 09:50:49 UTC Artifacts will be uploaded here
2025-03-07 09:53:33 UTC ya make is running...
🟡 2025-03-07 11:28:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12133 11881 0 184 32 36

2025-03-07 11:30:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 11:49:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
317 (only retried tests) 261 0 18 7 31

2025-03-07 11:49:13 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 12:01:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 60 0 0 4 28

🟢 2025-03-07 12:01:29 UTC Build successful.
🟡 2025-03-07 12:01:59 UTC ydbd size 3.7 GiB changed* by +322.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a790a6d merge: a71b5d4 diff diff %
ydbd size 3 994 271 672 Bytes 3 994 602 080 Bytes +322.7 KiB +0.008%
ydbd stripped size 1 388 750 024 Bytes 1 388 830 888 Bytes +79.0 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 09:51:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for a71b5d4 has started.
2025-03-07 09:51:12 UTC Artifacts will be uploaded here
2025-03-07 09:54:03 UTC ya make is running...
🟡 2025-03-07 11:17:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26498 23916 0 2 2466 114

2025-03-07 11:19:33 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 11:36:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 57 0 0 0 104

🟢 2025-03-07 11:36:18 UTC Build successful.
🟢 2025-03-07 11:36:37 UTC ydbd size 2.1 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1237379 merge: a71b5d4 diff diff %
ydbd size 2 293 645 624 Bytes 2 293 647 920 Bytes +2.2 KiB +0.000%
ydbd stripped size 480 484 512 Bytes 480 484 960 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lex007in lex007in requested a review from snaury March 7, 2025 12:27
@lex007in lex007in marked this pull request as ready for review March 7, 2025 12:27
@lex007in lex007in self-assigned this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant