Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MSVC version of the Rust compiler on AppVeyor #293

Closed
micbou opened this issue Jan 5, 2016 · 1 comment · Fixed by #401
Closed

Use MSVC version of the Rust compiler on AppVeyor #293

micbou opened this issue Jan 5, 2016 · 1 comment · Fixed by #401

Comments

@micbou
Copy link
Collaborator

micbou commented Jan 5, 2016

In PR #268, we use the gnu version of the Rust compiler on AppVeyor because the MSVC version does not support the new windows 10 SDK. This is fixed in the development branch of Rust but it will take some time to land in the stable version. According to Rust release process, the fix should be available in the 1.7 version (in about two months).

Meanwhile, we cannot apply the vcvars workaround because it sets the Omnisharp build configuration to 64-bit release mode, resulting in a failed build.

Our plan is to use the gnu version on AppVeyor until the stable release contains the fix. We will then replace it with the MSVC version.
@Valloric
Copy link
Member

Valloric commented Jan 6, 2016

Thanks for filing this!

@micbou micbou mentioned this issue Feb 28, 2016
Merged
@homu homu closed this as completed in #401 Feb 28, 2016
homu added a commit that referenced this issue Feb 28, 2016
@homu
Auto merge of #401 - micbou:appveyor-rust-msvc, r=vheon
d96c492 
[READY] Use MSVC version of the Rust compiler on AppVeyor

I found out that they backported the fix in Rust 1.6 so here we go. Fixes #293.

@jwilm You may update `appveyor.yml` in `racerd` repository too.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/401)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[READY] Use MSVC version of the Rust compiler on AppVeyor micbou/ycmd
2 participants
@Valloric @micbou