fix: strip trailing semicolon in cosmosdb and unify implementation #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes, in part, #511 .
cosmosdb, like several other databases, needs trailing semicolons to be
removed from the statement before it is passed to the driver.
This fix applies that to cosmosdb and makes the other databases with identical
processing use the same implementation - presto, trino, athena, SAP ASE.
Drivers that strip trailing semicolon as part of other processing are
not included in the refactoring to keep scope small.
Testing: with xo/dburl#44 applied , testing cosmosdb ...
Also tested with trino.