Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpdoc #262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix phpdoc #262

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Mar 5, 2025 •
edited
Loading

Description

Hi @nicknisi

Current phpdoc is wrong and lead to misuage of method or static analysis errors.

Client::request returns an array
and constructFromResponse accepts an array.

a new patch release with this would be great

Documentation

No need

@VincentLanglet VincentLanglet requested a review from a team as a code owner March 5, 2025 11:22
@VincentLanglet VincentLanglet requested a review from mattgd March 5, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgd mattgd Awaiting requested review from mattgd mattgd is a code owner automatically assigned from workos/php

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VincentLanglet