Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an introduction to suspense to the migration guide #912

Merged
merged 2 commits into from
Mar 7, 2021

Conversation

skirtles-code
Copy link
Contributor

@skirtles-code skirtles-code commented Feb 24, 2021

Issue: #328

Rendered: https://deploy-preview-912--vue-docs-next-preview.netlify.app/guide/migration/suspense.html

This adds a basic introduction to <suspense> within the migration guide. As an experimental feature it has not yet been added to the main guide or the API Reference. An entry in the migration guide should allow more people to try it out.

I put together a JSFiddle, based on the Vue Router example, for anyone who wants to experiment with this:

https://jsfiddle.net/skirtle/wyd2fveg/

References:


## Combining with Other Components

The following example shows how to combine `<router-view>`, `<transition>`, `<keep-alive>`, and `<suspense>`. For simpler combinations you can remove the components that you don't need:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skirtles-code should we add a link to vue-router docs here? People who didn't work with it might be surprised with router-view as it's not present in the core docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now reworded this part to assume less prior knowledge of Vue Router, as well as a link.

@skirtles-code skirtles-code marked this pull request as ready for review March 2, 2021 13:44
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this guide very much 👍🏻 (actually I learned a lot myself from it). Go @skirtles-code!

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for creating this. Great work!

@bencodezen bencodezen merged commit 5fe8e0d into vuejs:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants