Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add Phi4-MM example #14343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeejeelee
Copy link
Collaborator

No description provided.

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from DarkLight1337 March 6, 2025 08:33
Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 6, 2025
@DarkLight1337
Copy link
Member

Is this for testing only? The example scripts shouldn't use LoRA.

@Isotr0py
Copy link
Collaborator

Isotr0py commented Mar 6, 2025

I think we should also add audio example for phi-4-mm, since it supports audio inputs as well.

@jeejeelee
Copy link
Collaborator Author

Is this for testing only? The example scripts shouldn't use LoRA.

I implemented this example by referring to #14119 (comment). It looks like that LoRA is necessary.

@DarkLight1337
Copy link
Member

I looked further and yeah it seems that LoRA needs to be built into this model. We can keep the example as is then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants