Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Ensure out-of-tree quantization method recognize by cli args #14328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liuyanyi
Copy link
Contributor

@liuyanyi liuyanyi commented Mar 6, 2025

#11969 support the register of out-of-tree quantization method, but the cli args cant load the updated QUANTIZATION_METHODS

In this pr, The validation of quantization methods (QUANTIZATION_METHODS) is now performed after loading all plugins in the post_init method of EngineArgs.
This change ensures that any newly registered quantization methods are available during validation.

This pr also allow write a quantization plugin in a general_plugin

For example:

@register_quantization_config("awq_turbomind")
class AWQTurbomindConfig(QuantizationConfig):
# Entrypoint
def register():
    from vllm.model_executor.layers.linear import WEIGHT_LOADER_V2_SUPPORTED

    # Register the quantization method
    from .turbomind_awq import (  # noqa: F401
        AWQTurbomindConfig,
        AWQTurbomindLinearMethod,
    )

    # This is needed for correct weight loading
    WEIGHT_LOADER_V2_SUPPORTED.append("AWQTurbomindLinearMethod")

After install this plugin, i can use the openai server without any code modify.

vllm serve qwen/qwq-32b-awq -q awq_turbomind

Signed-off-by: liuyanyi <[email protected]>
Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@liuyanyi liuyanyi changed the title [Misc] Ensure out-of-tree [Misc] Ensure out-of-tree quantization method recognize by cli args Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant