[Bugfix][Core] fix abort_seq_group and memory leak when n>1 #14326
+31
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix two bugs when there are requests with n>1:
It's easy to reproduce the first bug: serve a model, make a curl request with n>1 and stream=True, and then press CTRL-C quickly. For easier reproduction, I recommend set larger max_tokens and ignore_eos=True.
Before this fix, you can see they are still running after the
Aborted request
log:After this fix, everything is OK: