-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Enable chunked prefill/paged attention in MLA on ROCm #14316
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sage Moore <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts?
@@ -1411,7 +1413,7 @@ def _forward_prefill( | |||
v_padded = torch.nn.functional.pad(v, [0, q.shape[-1] - v.shape[-1]], | |||
value=0) | |||
|
|||
if is_hip and envs.VLLM_USE_TRITON_FLASH_ATTN: | |||
if is_hip and envs.VLLM_USE_TRITON_FLASH_ATTN and has_context is False: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if is_hip and envs.VLLM_USE_TRITON_FLASH_ATTN and has_context is False: | |
if is_hip and envs.VLLM_USE_TRITON_FLASH_ATTN and not has_context: |
@@ -1322,7 +1323,8 @@ def _compute_prefill_context( | |||
[0, q.shape[-1] - v.shape[-1]], | |||
value=0) | |||
|
|||
if is_hip and envs.VLLM_USE_TRITON_FLASH_ATTN: | |||
if is_hip and envs.VLLM_USE_TRITON_FLASH_ATTN and \ | |||
has_context is False: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has_context is False: | |
not has_context: |
This PR is largely just removing the guards in config.py to allow chunked prefill and paged attention in MLA. The LSE computation in the triton kernel doesn't work so we always fall back to flash attention in this case.
I ran
lm_eval --model vllm --model_args pretrained=deepseek-ai/DeepSeek-Coder-V2-Lite-Instruct,trust_remote_code=True,enable_chunked_prefill=True --tasks gsm8k --num_fewshot 5 --batch_size auto
and gotCC: @LucasWilkinson