-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Add needs_fixed_stride_order tag to most GEMMs #14306
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tyler Michael Smith <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
For some more context, this was a mistake and we're going to flip the default back in PyTorch 2.7. Is it possible to only set the tag for PyTorch 2.6? The reason why I ask is in PyTorch 2.8 we're going to flip the default again to something better ("match exact eager-mode strides") and setting it to |
Ah, thanks for that context. I'll try it |
(that being said, I don't know how to actually switch on the PyTorch version like that in C++, so if it's not possible we can just leave a mental note here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM! Maybe we could override ops to add a wrapper function, but still it wouldn't be clear which functions require it.
PyTorch 2.6.0 changed the default behavior for custom operators to be "requires_contiguous". In GEMM kernels, we often transpose or otherwise transform our weights offline, which would be in conflict with this change. This PR changes adds
{at::Tag::needs_fixed_stride_order}
to most GEMMs incsrc/torch_bindings.cpp
See #12721 (comment)