Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Improve LoRA spelling #13831

Merged
merged 3 commits into from
Feb 26, 2025
Merged

[Misc] Improve LoRA spelling #13831

merged 3 commits into from
Feb 26, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 25, 2025 •
edited by github-actions bot
Loading

No description provided.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend speculative-decoding labels Feb 25, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 25, 2025 16:15
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@vllm-bot vllm-bot merged commit 5157338 into vllm-project:main Feb 26, 2025
42 of 45 checks passed
@jeejeelee jeejeelee deleted the fix-lora-typo branch February 26, 2025 08:12
@joerunde joerunde mentioned this pull request Feb 27, 2025
Merged
Akshat-Tripathi added a commit to krai/vllm that referenced this pull request Mar 3, 2025
@Akshat-Tripathi
[Misc] Improve LoRA spelling (vllm-project#13831)
241fa24
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
@jeejeelee @lk-chen
[Misc] Improve LoRA spelling (vllm-project#13831)
4c67dd8 
Signed-off-by: Linkun Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeejeelee @DarkLight1337 @vllm-bot