Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf-benchmark] Allow premerge ECR #13509

Merged
merged 1 commit into from
Feb 19, 2025
Merged

[perf-benchmark] Allow premerge ECR #13509

merged 1 commit into from
Feb 19, 2025

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Feb 19, 2025 •
edited
Loading

Use vllm-ci-test-repo if perf benchmark is triggered from PR

p
71af72e 
Signed-off-by:  <>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 19, 2025
ywang96
ywang96 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@ywang96 ywang96 enabled auto-merge (squash) February 19, 2025 03:48
@ywang96 ywang96 merged commit 9aa95b0 into main Feb 19, 2025
43 of 46 checks passed
@ywang96 ywang96 deleted the khluu/benchmark_fix branch February 19, 2025 05:13
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@khluu
[perf-benchmark] Allow premerge ECR (vllm-project#13509)
2ad0ade 
Signed-off-by: <>
Co-authored-by: EC2 Default User <[email protected]>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@khluu @kerthcet
[perf-benchmark] Allow premerge ECR (vllm-project#13509)
15cbcdc 
Signed-off-by: <>
Co-authored-by: EC2 Default User <[email protected]>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@khluu @Akshat-Tripathi
[perf-benchmark] Allow premerge ECR (vllm-project#13509)
52b3192 
Signed-off-by: <>
Co-authored-by: EC2 Default User <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
@khluu @lk-chen
[perf-benchmark] Allow premerge ECR (vllm-project#13509)
a4e0f22 
Signed-off-by: <>
Co-authored-by: EC2 Default User <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ci/build perf-benchmarks ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khluu @ywang96